Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): catalog pagination through continuation token and Link header #4103

Merged
merged 1 commit into from Apr 15, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 10, 2024

What this PR changes/adds

Implement pagination as described by DSP specification.
The continuationToken is the json representation of a QuerySpec object encoded in base64.

The core of the implementation is the ContinuationTokenManager component that provides two features:

  • being able to eventually deserialize and apply to the requestBody the continuationToken
  • set the Link header on the response through the ResponseDecorator

Why it does that

dsp completion

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3866

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Apr 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.73239% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 74.71%. Comparing base (7f20ba5) to head (30dc870).
Report is 210 commits behind head on main.

Files Patch % Lines
...main/java/org/eclipse/edc/spi/query/QuerySpec.java 41.66% 7 Missing ⚠️
...tp/api/decorator/ContinuationTokenManagerImpl.java 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4103      +/-   ##
==========================================
+ Coverage   71.74%   74.71%   +2.97%     
==========================================
  Files         919      982      +63     
  Lines       18457    20142    +1685     
  Branches     1037     1133      +96     
==========================================
+ Hits        13242    15050    +1808     
+ Misses       4756     4598     -158     
- Partials      459      494      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 949a7ed into eclipse-edc:main Apr 15, 2024
21 of 24 checks passed
@ndr-brt ndr-brt deleted the 3866-catalog-pagination branch April 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSP 1.0: catalog pagination
3 participants