chore: removes OAuth2 capabilities from the data sink #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4152 +/- ##
==========================================
+ Coverage 71.74% 74.93% +3.18%
==========================================
Files 919 986 +67
Lines 18457 20269 +1812
Branches 1037 1142 +105
==========================================
+ Hits 13242 15188 +1946
+ Misses 4756 4583 -173
- Partials 459 498 +39 ☔ View full report in Codecov by Sentry. |
paullatzelsperger
approved these changes
May 2, 2024
...t/java/org/eclipse/edc/connector/dataplane/http/oauth2/DataPlaneHttpOauth2ExtensionTest.java
Outdated
Show resolved
Hide resolved
jimmarino
approved these changes
May 2, 2024
|
It would be great to know what the reason for the removal is. I have no argument against the removal, I'm just curious and the PR description is more or less non-existent... |
|
The reasons for this removal will be explained by the committers later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
removes OAuth2 capabilities from the data sink