Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused parentPermission field that caused stack overflow exceptions #4155

Merged
merged 1 commit into from May 3, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 3, 2024

What this PR changes/adds

Remove unneeded parentPermission from Duty that caused StackOverflowException in json serialization.

Why it does that

cleanup

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3830

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added bug Something isn't working policy labels May 3, 2024
@ndr-brt ndr-brt requested review from wolf4ood and jimmarino May 3, 2024 08:48
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.94%. Comparing base (7f20ba5) to head (0d2a0f2).
Report is 235 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4155      +/-   ##
==========================================
+ Coverage   71.74%   74.94%   +3.20%     
==========================================
  Files         919      986      +67     
  Lines       18457    20259    +1802     
  Branches     1037     1141     +104     
==========================================
+ Hits        13242    15184    +1942     
+ Misses       4756     4578     -178     
- Partials      459      497      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 0843fe4 into eclipse-edc:main May 3, 2024
18 of 20 checks passed
@ndr-brt ndr-brt deleted the 3830-avoid-soe branch May 3, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflowError when creating a policy with duty within its permissions
3 participants