Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete unused launcher #4199

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 20, 2024

What this PR changes/adds

delete data-plane-server, as it's not really used and it's not clear what it's supposed to achieve.

Why it does that

cleanup

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4198

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label May 20, 2024
@ndr-brt ndr-brt requested a review from wolf4ood May 20, 2024 12:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.02%. Comparing base (7f20ba5) to head (3a90884).
Report is 265 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4199      +/-   ##
==========================================
+ Coverage   71.74%   75.02%   +3.27%     
==========================================
  Files         919     1015      +96     
  Lines       18457    20656    +2199     
  Branches     1037     1165     +128     
==========================================
+ Hits        13242    15497    +2255     
+ Misses       4756     4649     -107     
- Partials      459      510      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit a553d54 into eclipse-edc:main May 20, 2024
18 of 22 checks passed
@ndr-brt ndr-brt deleted the 4198-remove-data-plane-launcher branch May 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove data-plane-server launcher
3 participants