Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove FsVault #4202

Merged

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Removes the FsVault

Why it does that

It was inconsistent, and maintaining it was not worth the effort. We have an easy-to-use OSS alternative (Hashicorp), and an in-mem variant for testing.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request refactoring Cleaning up code and dependencies labels May 21, 2024
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (7f20ba5) to head (5e46025).
Report is 267 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4202      +/-   ##
==========================================
- Coverage   71.74%   67.34%   -4.41%     
==========================================
  Files         919     1010      +91     
  Lines       18457    20544    +2087     
  Branches     1037     1154     +117     
==========================================
+ Hits        13242    13835     +593     
- Misses       4756     6236    +1480     
- Partials      459      473      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger marked this pull request as ready for review May 21, 2024 15:56
@paullatzelsperger paullatzelsperger merged commit b929b37 into eclipse-edc:main May 21, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/remove_fsvault branch May 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants