-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: first JSON-LD context for management api #4256
Merged
wolf4ood
merged 4 commits into
eclipse-edc:main
from
wolf4ood:feat/4255_jsonld_context_mgmt
Jun 14, 2024
Merged
feat: first JSON-LD context for management api #4256
wolf4ood
merged 4 commits into
eclipse-edc:main
from
wolf4ood:feat/4255_jsonld_context_mgmt
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c96fd71
to
12d5b73
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4256 +/- ##
==========================================
+ Coverage 71.74% 75.03% +3.29%
==========================================
Files 919 1047 +128
Lines 18457 20997 +2540
Branches 1037 1172 +135
==========================================
+ Hits 13242 15756 +2514
+ Misses 4756 4727 -29
- Partials 459 514 +55 ☔ View full report in Codecov by Sentry. |
65e9746
to
ef3e4d2
Compare
ef3e4d2
to
53fcf31
Compare
paullatzelsperger
approved these changes
Jun 14, 2024
...-ld-context/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
Outdated
Show resolved
Hide resolved
...lipse/edc/connector/api/management/jsonld/serde/ManagementApiJsonLdContextExtensionTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Jun 14, 2024
...ntext/src/test/java/org/eclipse/edc/connector/api/management/jsonld/serde/TestFunctions.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Why it does that
dev experience
Further notes
Currently the context is cached and associated with the URL
https://w3id.org/edc/connector/management/v0.0.1
which is yet to be decided in the final form.Since using the
odrl
context at root level could lead some issue when compacting on egress, it's automatically defined as local context when defining thepolicy
term.There is still an issue when compacting the
@type
of theodrl
policy where currently the local context is not applied thereFor performance reason all
ser/de
tests are in a single class with a class level e2e runtime.Linked Issue(s)
Closes #4255
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.