Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first JSON-LD context for management api #4256

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jun 10, 2024

What this PR changes/adds

  • Draft a JSON-LD context for the management api
  • Introduces an experimental extension that register the context in the management api scope
  • E2E serialization/deserialization of management api entities using the context.

Why it does that

dev experience

Further notes

Currently the context is cached and associated with the URL https://w3id.org/edc/connector/management/v0.0.1 which is yet to be decided in the final form.

Since using the odrl context at root level could lead some issue when compacting on egress, it's automatically defined as local context when defining the policy term.

There is still an issue when compacting the @type of the odrl policy where currently the local context is not applied there

For performance reason all ser/de tests are in a single class with a class level e2e runtime.

Linked Issue(s)

Closes #4255

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Jun 10, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Jun 10, 2024
@wolf4ood wolf4ood force-pushed the feat/4255_jsonld_context_mgmt branch from c96fd71 to 12d5b73 Compare June 10, 2024 12:57
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.03%. Comparing base (7f20ba5) to head (52aaa49).
Report is 304 commits behind head on main.

Files Patch % Lines
...nt/jsonld/ManagementApiJsonLdContextExtension.java 73.33% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4256      +/-   ##
==========================================
+ Coverage   71.74%   75.03%   +3.29%     
==========================================
  Files         919     1047     +128     
  Lines       18457    20997    +2540     
  Branches     1037     1172     +135     
==========================================
+ Hits        13242    15756    +2514     
+ Misses       4756     4727      -29     
- Partials      459      514      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/4255_jsonld_context_mgmt branch 6 times, most recently from 65e9746 to ef3e4d2 Compare June 14, 2024 07:36
@wolf4ood wolf4ood force-pushed the feat/4255_jsonld_context_mgmt branch from ef3e4d2 to 53fcf31 Compare June 14, 2024 07:56
@wolf4ood wolf4ood marked this pull request as ready for review June 14, 2024 08:28
@wolf4ood wolf4ood requested a review from jimmarino June 14, 2024 08:28
@wolf4ood wolf4ood merged commit aa431ac into eclipse-edc:main Jun 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft JSON-LD context for management API.
4 participants