Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add check for management-api modification #4283

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 18, 2024

What this PR changes/adds

Adds a workflow that checks:

  • if no changes done on the management api version.json file
    • check if there are difference from a generated openapi file and the one published on github pages

Why it does that

Briefly state why the change was necessary.

Further notes

  • please note that at this moment this check will fail all the time, because the api that are published on github pages are published with the EDC version, and not with their version (this need to change), so please not merge this PR yet

Linked Issue(s)

Closes #4182

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added api Feature related to the (REST) api build Anything related to the CI/CD Pipeline on Github Actions labels Jun 18, 2024
@ndr-brt ndr-brt requested a review from wolf4ood June 18, 2024 14:25
@ndr-brt ndr-brt force-pushed the 4182-management-api-version-bump branch 10 times, most recently from 8e3f6ff to 936eb38 Compare June 20, 2024 08:28
@ndr-brt ndr-brt force-pushed the 4182-management-api-version-bump branch from 936eb38 to 62ae5d6 Compare June 20, 2024 08:52
@ndr-brt ndr-brt force-pushed the 4182-management-api-version-bump branch from 7dfa26b to aea7848 Compare June 20, 2024 12:11
@ndr-brt ndr-brt merged commit 4f69022 into eclipse-edc:main Jun 21, 2024
22 checks passed
@ndr-brt ndr-brt deleted the 4182-management-api-version-bump branch June 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api build Anything related to the CI/CD Pipeline on Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management API: add workflow to assert version bump
2 participants