Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch ContractAgreement to connector client #116

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 17, 2023

What this PR changes/adds

Make the ContractAgreement service to use the connector client

Why it does that

refactoring

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #54

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Oct 17, 2023
@ndr-brt ndr-brt changed the title feat: switch to connector client feat: switch ContractAgreement to connector client Oct 17, 2023
Copy link
Contributor

@janpmeyer janpmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Client API-Changes Look good for me.

Mabey we just need to open a new Issue about the style of the Contract Name

@ndr-brt ndr-brt merged commit d80cc00 into eclipse-edc:main Oct 19, 2023
3 of 5 checks passed
@ndr-brt ndr-brt deleted the 54-switch-contractagreement branch October 19, 2023 06:31
farhin23 pushed a commit to FraunhoferISST/edc-dashboard that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector client: switch ContractAgreementService
2 participants