Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump swagger dependency and refactor #178

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Sep 8, 2023

What this PR changes/adds

Bump the injected swagger-jaxrs2-jakarta dependency version.
Cleaned up things a little, removed the gradle-swagger-generator-plugin that was not used anymore

Why it does that

Briefly state why the change was necessary.

Further notes

  • it would be great to have a way to get that version number from the catalog so dependabot can take care of updating it.

@ndr-brt ndr-brt added bug Something isn't working dependencies labels Sep 8, 2023
@ndr-brt ndr-brt force-pushed the bump-swagger-jaxrs2-jakarta-version branch from dc2a068 to 57b2a79 Compare September 8, 2023 08:23
@ndr-brt ndr-brt changed the title build: build swagger deps and refactor build: bump swagger dependency and refactor Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Test Results

39 tests  ±0   39 ✔️ ±0   22s ⏱️ -2s
10 suites ±0     0 💤 ±0 
10 files   ±0     0 ±0 

Results for commit 4c5029f. ± Comparison against base commit 39a5c5c.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
org.eclipse.edc.plugins.edcbuild.conventions.SwaggerGeneratorConventionTest ‑ apply_whenApiGroupNotSpecified_shouldUseDefault()
org.eclipse.edc.plugins.edcbuild.conventions.SwaggerGeneratorConventionTest ‑ apply_whenApiGroupSpecified_shouldAppend()
org.eclipse.edc.plugins.edcbuild.conventions.SwaggerGeneratorConventionTest ‑ apply_whenOutputDirSet_shouldAppend()
org.eclipse.edc.plugins.edcbuild.conventions.SwaggerResolveConventionTest ‑ apply_whenApiGroupNotSpecified_shouldUseDefault()
org.eclipse.edc.plugins.edcbuild.conventions.SwaggerResolveConventionTest ‑ apply_whenApiGroupSpecified_shouldAppend()
org.eclipse.edc.plugins.edcbuild.conventions.SwaggerResolveConventionTest ‑ apply_whenOutputDirSet_shouldAppend()

♻️ This comment has been updated with latest results.

@paullatzelsperger paullatzelsperger merged commit 5a251a0 into main Sep 8, 2023
17 checks passed
@ndr-brt ndr-brt deleted the bump-swagger-jaxrs2-jakarta-version branch September 8, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants