feat: autodoc - render configuration defaultValue #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
184-default-value
branch
from
9e17891
to
b659690
Compare
ndr-brt
force-pushed
the
184-default-value
branch
from
b659690
to
48c05b2
Compare
| settingBuilder.minimum(min); | ||
|
|
||
| return settingBuilder.build(); | ||
| return ConfigurationSetting.Builder.newInstance().key(keyValue) |
There was a problem hiding this comment.
how on earth did I ever think that is good code 🤣
thanks for cleaning up!
paullatzelsperger
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Render the
defaultValueattribute of the@Settingannotation in the autodoc pluginWhy it does that
documentation
Further notes
Linked Issue(s)
Closes #184
Checklist
no-changelog)