Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add defaultValue to @Setting #53

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Nov 21, 2022

What this PR changes/adds

Add a defaultValue() method to @Setting

Why it does that

Improve documentation

Further notes

  • set rootProject.name equal to the repository name GradlePlugins, for coherency

Linked Issue(s)

Closes #52

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt added the enhancement New feature or request label Nov 21, 2022
@ndr-brt ndr-brt changed the title feat: add defaultvalue to setting feat: add defaultValue to @Setting Nov 21, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@github-actions
Copy link

github-actions bot commented Nov 21, 2022

Test Results

38 tests  ±0   38 ✔️ ±0   21s ⏱️ +5s
12 suites ±0     0 💤 ±0 
12 files   ±0     0 ±0 

Results for commit 8b35173. ± Comparison against base commit 1c7329c.

♻️ This comment has been updated with latest results.

@ndr-brt ndr-brt force-pushed the feat/52-add-defaultvalue-to-setting branch from 4377d89 to 8b35173 Compare November 21, 2022 15:25
@paullatzelsperger paullatzelsperger merged commit 097802b into main Nov 21, 2022
@ndr-brt ndr-brt deleted the feat/52-add-defaultvalue-to-setting branch January 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add defaultValue to @Setting
2 participants