Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump aws-sdk-java-v2 to 2.19.26 #76

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

iwasakims
Copy link
Contributor

@iwasakims iwasakims commented Jan 30, 2023

What this PR changes/adds

bump the version of aws-sdk-java-v2 to 2.19.26 which supports virtual-hosted style URL with endpoint override.

Why it does that

as a prerequisite of eclipse-edc/Technology-Aws#28

Further notes

Existing S3 tests of Connector passed against 2.19.26. (I needed to modify dependencyResolutionManagement of settings.gradle.kts to make edc-versions picked from local Maven repo.)

$ cd path/to/GradlePlugins
$ ./gradlew clean build publishToMavenLocal -Pskip.signing
$ cd path/to/Connector
$ git diff
diff --git a/settings.gradle.kts b/settings.gradle.kts
index d280746e4..e88155c55 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -30,11 +30,11 @@ pluginManagement {

 dependencyResolutionManagement {
     repositories {
+        mavenLocal()
         maven {
             url = uri("https://oss.sonatype.org/content/repositories/snapshots/")
         }
         mavenCentral()
-        mavenLocal()
     }
     versionCatalogs {
         create("libs") {
$ docker run -d -p 9000:9000 -e MINIO_ROOT_USER=root -e MINIO_ROOT_PASSWORD=password bitnami/minio:latest

$ S3_ACCESS_KEY_ID=root S3_SECRET_ACCESS_KEY=password ./gradlew -p extensions/data-plane/data-plane-aws-s3 clean test -DincludeTags="AwsS3IntegrationTest"
...
> Task :extensions:control-plane:provision:provision-aws-s3:test

---------------------------------------------------------------
|  Results: SUCCESS (6 tests, 6 passed, 0 failed, 0 skipped)  |
---------------------------------------------------------------

$ S3_ACCESS_KEY_ID=root S3_SECRET_ACCESS_KEY=password ./gradlew -p extensions/control-plane/provision/provision-aws-s3 clean test -DincludeTags="AwsS3IntegrationTest"
...
> Task :extensions:data-plane:data-plane-aws-s3:test

---------------------------------------------------------------
|  Results: SUCCESS (1 tests, 1 passed, 0 failed, 0 skipped)  |
---------------------------------------------------------------

Checklist

  • [n/a] added appropriate tests?
  • performed checkstyle check locally?
  • [n/a] added/updated copyright headers?
  • [n/a] documented public classes/methods?
  • [n/a] added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

Signed-off-by: Masatake Iwasaki <iwasakims@gmail.com>
@ndr-brt ndr-brt merged commit 35e3cb5 into eclipse-edc:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants