-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ParticipantStore): add SQL store #43
feat(ParticipantStore): add SQL store #43
Conversation
5da0d01
to
e88b138
Compare
e88b138
to
979994a
Compare
...i/src/main/java/org/eclipse/dataspaceconnector/registration/authority/model/Participant.java
Outdated
Show resolved
Hide resolved
testFixturesImplementation("org.junit.jupiter:junit-jupiter-params:${jupiterVersion}") | ||
testFixturesRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:${jupiterVersion}") | ||
testFixturesImplementation("org.assertj:assertj-core:${assertj}") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit concerned about pulling dependencies on other extensions and on test libraries into the *-spi
directory. But maybe it's acceptable if it's only test fixture implementations... @paullatzelsperger what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bscholtes1A the deps to authority-spi
can be easily removed since it's only one fixture. But since the model is there it made sense to use that module fixtures
The test engine it's needed. We did the same thing on the other stores by providing a base test for all the store implementation like here
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/main/spi/control-plane/contract-spi/build.gradle.kts#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bscholtes1A @wolf4ood I would slightly lean toward ben's position, i.e. removing the dependency onto dataspace-authority-spi
, because we're only using a simple factory method, but I don't think this is a big issue either way.
979994a
to
48794bf
Compare
48794bf
to
1bee240
Compare
1bee240
to
20e07b6
Compare
What this PR changes/adds
Add SQL store implementation for ParticipantStore
Why it does that
Durability of participants and scalability for the Registration service
Linked Issue(s)
Closes #41
Checklist
no-changelog
)