feat: create samples for the http data proxy flow #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
ndr-brt
requested changes
Jan 30, 2023
transfer/transfer-06-http-data-flow/backend-service/build.gradle.kts
Outdated
Show resolved
Hide resolved
...06-http-data-flow/backend-service/src/main/java/org/eclipse/edc/handler/ReceiverHandler.java
Outdated
Show resolved
Hide resolved
...06-http-data-flow/backend-service/src/main/java/org/eclipse/edc/handler/ReceiverHandler.java
Outdated
Show resolved
Hide resolved
ronjaquensel
reviewed
Feb 1, 2023
There was a problem hiding this comment.
Looks good overall, a few comments in-line. And could you add the new sample to the CODEOWNERS file and add @ndr-brt as a responsible there?
ndr-brt
approved these changes
Feb 9, 2023
ronjaquensel
approved these changes
Feb 10, 2023
|
Looks good. Please also sign the ECA so then we can merge the PR. |
Alexwilfriedo
force-pushed
the
feature#1580_create_samples_for_the_HttpData_proxy_flow
branch
from
b9a5136
to
7382321
Compare
chore: squash 4 commits to 1 chore: fix issues related to keystore chore: apply review recommendation chore: apply review recommendation chore: apply review recommendation chore: improve README.md documentation feat: en backend service implementation and add more explaination to the Readme.md feat: en backend service implementation and add more explaination to the Readme.md feat: Add a little http-server module to handle edc.receiver.http.endpoint request WIP: working on documenting the http data flow feat: create and configure a consumer feat: create and configure a provider chore: refactor http-data-flow module name and reorganize the sample module
Alexwilfriedo
force-pushed
the
feature#1580_create_samples_for_the_HttpData_proxy_flow
branch
from
7382321
to
9a1d825
Compare
|
Hello @ronjaquensel , the ECA issue had been fixed. |
ndr-brt
deleted the
feature#1580_create_samples_for_the_HttpData_proxy_flow
branch
Alexwilfriedo
pushed a commit
to Think-iT-Labs/edc-samples
that referenced
this pull request
Feb 20, 2023
feat: create samples for the http data proxy flow (eclipse-edc#8) * chore: create base module and add consumer and IT modules * chore: create base module and add consumer and IT modules * chore: squash 12 commits to 1 chore: squash 4 commits to 1 chore: fix issues related to keystore chore: apply review recommendation chore: apply review recommendation chore: apply review recommendation chore: improve README.md documentation feat: en backend service implementation and add more explaination to the Readme.md feat: en backend service implementation and add more explaination to the Readme.md feat: Add a little http-server module to handle edc.receiver.http.endpoint request WIP: working on documenting the http data flow feat: create and configure a consumer feat: create and configure a provider chore: refactor http-data-flow module name and reorganize the sample module feat: done with README.md feat: create http-push-connector chore: update edc version to 1.0.0-milestone-8 and improve documentation chore: fix issues related to keystore chore: apply review recommendation chore: apply review recommendation chore: apply review recommendation chore: improve README.md documentation feat: en backend service implementation and add more explaination to the Readme.md feat: en backend service implementation and add more explaination to the Readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR add a sample to demonstrate a consumer pull data flow between two connectors (on provider and one consumer)
Why it does that
This example shows, step by step, the steps to obtain an asset from the consumer based on a contract with a provider.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #22
Checklist