Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#35: angus activation does not provide its services in an OSGi environment #36

Merged
merged 1 commit into from
Apr 25, 2023
Merged

#35: angus activation does not provide its services in an OSGi environment #36

merged 1 commit into from
Apr 25, 2023

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Apr 25, 2023

fixes #35

@lukasj lukasj changed the title #:35: angus activation does not provide its services in an OSGi environment #35: angus activation does not provide its services in an OSGi environment Apr 25, 2023
@lukasj
eclipse-ee4j#35: angus activation does not provide its services in a…
13d2b3b 
…n OSGi environment

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj mentioned this pull request Apr 25, 2023
Closed
mnlipp
mnlipp approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@mnlipp mnlipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tried it, works. The providers are registered as services of the expected type now. My sample application could (finally) be started without hk2.osgi-resource-locator.

@lukasj
Copy link
Member Author

lukasj commented Apr 25, 2023

Thanks for testing this. I'll apply the same change to other projects in the next few days. Thanks!

@lukasj lukasj merged commit 7b46fc2 into eclipse-ee4j:master Apr 25, 2023
2 checks passed
@lukasj lukasj deleted the is35 branch April 25, 2023 17:07
@mnlipp
Copy link
Contributor

mnlipp commented Apr 26, 2023

Thanks for testing this. I'll apply the same change to other projects in the next few days. Thanks!

BTW I'm pondering about this since yesterday: why did you add these osgi.service;objectClass=... "statements"?

@lukasj
Copy link
Member Author

lukasj commented Apr 26, 2023

TBH I don't recall. I think I've added OSGi dependency and annotations, let felix generate the manifest, took what was there in the generated manifest and removed dependency etc. Do you think it can go away?

@mnlipp
Copy link
Contributor

mnlipp commented Apr 26, 2023

Do you think it can go away?

Yes, see #37. Going to test for angus mail as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnlipp mnlipp mnlipp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

angus activation does not provide its services in an OSGi environment
2 participants
@lukasj @mnlipp