add raw and uchecked to javac xlint for main sources

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
eclipse-ee4j · Sep 5, 2021 · 38592ca · 38592ca
1 parent 3a0a5fd
commit 38592ca
Show file tree

Hide file tree

Showing 6 changed files with 44 additions and 15 deletions.
diff --git a/bundles/eclipselink/pom.xml b/bundles/eclipselink/pom.xml
@@ -31,6 +31,12 @@
     </parent>
 
     <properties>
+        <jdoc.doclint>none</jdoc.doclint>
+        <!-- XXX deprecated comes from commonj.sdo which we don't want to touch -->
+        <comp.xlint>-Xlint:all,-serial,-deprecation,-dep-ann</comp.xlint>
+        <comp.test.xlint>-Xlint:none</comp.test.xlint>
+        <comp.xdoclint>-Xdoclint:none</comp.xdoclint>
+
         <gen.src.dir>${project.build.directory}/generated-sources/dependency-sources</gen.src.dir>
         <gen.zip.dir>${project.build.directory}/generated-sources/zip-sources</gen.zip.dir>
 

diff --git a/dbws/org.eclipse.persistence.dbws/pom.xml b/dbws/org.eclipse.persistence.dbws/pom.xml
@@ -32,7 +32,7 @@
 
     <properties>
         <!-- disable warnings for exports for now -->
-        <comp.xlint>-Xlint:all,-rawtypes,-unchecked,-serial,-exports</comp.xlint>
+        <comp.xlint>-Xlint:all,-serial,-exports</comp.xlint>
         <test-skip-dbws>${skipTests}</test-skip-dbws>
     </properties>
 

diff --git a/foundation/org.eclipse.persistence.core/pom.xml b/foundation/org.eclipse.persistence.core/pom.xml
@@ -32,8 +32,9 @@
 
     <properties>
         <!-- Too many to fix -->
-        <comp.xlint>-Xlint:all,-rawtypes,-unchecked,-serial,-exports</comp.xlint>
+        <comp.xlint>-Xlint:all,-serial,-exports</comp.xlint>
     </properties>
+
     <dependencies>
         <!--Other modules-->
         <dependency>

diff --git a/moxy/org.eclipse.persistence.moxy/pom.xml b/moxy/org.eclipse.persistence.moxy/pom.xml
@@ -31,7 +31,7 @@
     </parent>
 
     <properties>
-        <comp.xlint>-Xlint:all,-rawtypes,-unchecked,-serial,-exports</comp.xlint>
+        <comp.xlint>-Xlint:all,-serial,-exports</comp.xlint>
 
         <test-skip-moxy-jaxb-srg>${skipTests}</test-skip-moxy-jaxb-srg>
         <test-skip-moxy-jaxb>true</test-skip-moxy-jaxb>

diff --git a/pom.xml b/pom.xml
@@ -99,10 +99,10 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <jdoc.doclint>all,-missing</jdoc.doclint>
         <!-- exclude big groups from the Xlint -->
-        <comp.xlint>-Xlint:all,-rawtypes,-unchecked,-serial</comp.xlint>
-        <!-- -Xdoclint:-missing does not seem to work properly on the infra -->
+        <comp.xlint>-Xlint:all,-serial</comp.xlint>
         <comp.xdoclint>-Xdoclint:all,-missing</comp.xdoclint>
-        <warn.limit>150</warn.limit>
+        <comp.test.xlint>-Xlint:all,-rawtypes,-unchecked,-serial</comp.test.xlint>
+        <warn.limit>250</warn.limit>
 
         <spotbugs.common>${project.build.directory}/spotbugs-exclude-common.xml</spotbugs.common>
         <spotbugs.exclude/>
@@ -1216,15 +1216,35 @@
                     <release>11</release>
                     <showWarnings>true</showWarnings>
                     <showDeprecation>true</showDeprecation>
-                    <compilerArgs combine.children="append">
-                        <arg>${comp.xlint}</arg>
-                        <arg>${comp.xdoclint}</arg>
-                        <arg>-Xmaxwarns</arg>
-                        <arg>${warn.limit}</arg>
-                        <arg>-Xmaxerrs</arg>
-                        <arg>${warn.limit}</arg>
-                    </compilerArgs>
                 </configuration>
+                <executions>
+                    <execution>
+                        <id>default-compile</id>
+                        <configuration>
+                            <compilerArgs combine.children="append">
+                                <arg>${comp.xlint}</arg>
+                                <arg>${comp.xdoclint}</arg>
+                                <arg>-Xmaxwarns</arg>
+                                <arg>${warn.limit}</arg>
+                                <arg>-Xmaxerrs</arg>
+                                <arg>${warn.limit}</arg>
+                            </compilerArgs>
+                        </configuration>
+                    </execution>
+                    <execution>
+                        <id>default-testCompile</id>
+                        <configuration>
+                            <compilerArgs combine.children="append">
+                                <arg>${comp.test.xlint}</arg>
+                                <arg>${comp.xdoclint}</arg>
+                                <arg>-Xmaxwarns</arg>
+                                <arg>${warn.limit}</arg>
+                                <arg>-Xmaxerrs</arg>
+                                <arg>${warn.limit}</arg>
+                            </compilerArgs>
+                        </configuration>
+                    </execution>
+                </executions>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>

diff --git a/sdo/org.eclipse.persistence.sdo/pom.xml b/sdo/org.eclipse.persistence.sdo/pom.xml
@@ -33,8 +33,10 @@
     <properties>
         <dep.sources>${project.build.directory}/generated-sources/dependencies</dep.sources>
         <jdoc.doclint>-missing</jdoc.doclint>
-        <!-- XXX deprecated comes from commonj.sdo which we don't want to touch -->
+        <!-- XXX deprecated comes from commonj.sdo which we don't want to touch,
+             we also do not want to see what has already been reported earlier -->
         <comp.xlint>-Xlint:all,-rawtypes,-unchecked,-serial,-deprecation,-dep-ann</comp.xlint>
+        <comp.test.xlint>-Xlint:all,-rawtypes,-unchecked,-serial,-deprecation,-dep-ann</comp.test.xlint>
         <comp.xdoclint>-Xdoclint:none</comp.xdoclint>
 
         <test-skip-sdo-srg>${skipTests}</test-skip-sdo-srg>