Asm #1054
Merged
Asm #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a few comments: |
rfelcman
reviewed
Mar 31, 2021
lukasj
force-pushed
the
asm
branch
2 times, most recently
from
40dc149
to
3e2840b
Compare
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
add osgi headers to source bundle Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
rfelcman
requested changes
Apr 26, 2021
There was a problem hiding this comment.
Almost OK except mentioned minor comments.
Two things which should be optionally included there:
- New Travis-CI target something like
...
matrix:
- MAVEN_TEST=asm
...
- if [ "$MAVEN_TEST" == "asm" ]; then
cd plugins/org.eclipse.persistence.asm/;
mvn test;
fi
- Maybe make generated Javadoc little bit nicer (title, copyright year)
.../src/main/java/org/eclipse/persistence/internal/libraries/asm/EclipseLinkASMClassWriter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
|
wrt travis for asm - it is non-trivial to add it correctly - the one built by travis won't be the one used by main eclispelink build there without extra modification of eclipselink's pom - I don't think we want to be doing that wrt javadoc - I can see correct cp year in the javadoc footer; I don't think we need to customize the default more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1051 in master: