Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving MOXy on JPMS to experimental stage #1130

Merged
merged 7 commits into from May 13, 2021
Merged

Moving MOXy on JPMS to experimental stage #1130

merged 7 commits into from May 13, 2021

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented May 11, 2021 •
edited

  • integrated jaxb 3.0.2-b01
  • removed most refllection calls
  • fixed tests to run properly on JDK 11+
  • moved jaxb-compiler.sh/cmd on JDK9+ from class-path to module-path
  • replaced setAccessible calls by trySetAccessible, added FINE logging for cases when set fails

Notes:

  • running tests on modulepath directly in maven currently fails due to some strange issue with jsonp dependency (can be workarounded either by using org.eclipse.jsonp:jakarta.json:2.0.2-SNAPSHOT or possibly also by using standalone API and impl, not the all-in-one jar)
  • with previous workaround in place and running tests through ant (commented snippet in the moxy pom), I get to:
Tests | Failures | Errors | Skipped | Success rate
-- | -- | -- | -- | -- | --
24573 | 7 | 0 | 0 | 99.97%

where ~5 failures are likely configuration/setup issues on my end

  • jaxb 3.0.2-b01 is in staging only, I'll push it out once we see more test results on different setups (ie from travis)

@lukasj lukasj requested a review from rfelcman May 11, 2021 20:34
rfelcman
rfelcman reviewed May 13, 2021
View reviewed changes
bundles/eclipselink/pom.xml Show resolved Hide resolved
bundles/eclipselink/src/main/scripts/bin/jaxb-compiler.sh Outdated Show resolved Hide resolved
...nce.core/src/main/java/org/eclipse/persistence/internal/security/PrivilegedAccessHelper.java Outdated Show resolved Hide resolved
moxy/org.eclipse.persistence.moxy/pom.xml Show resolved Hide resolved
moxy/org.eclipse.persistence.moxy/src/main/java/org/eclipse/persistence/jaxb/JAXBContext.java Outdated Show resolved Hide resolved
.LCKpom.xml~ Outdated Show resolved Hide resolved
moxy/org.eclipse.persistence.moxy/pom.xml Show resolved Hide resolved
moxy/org.eclipse.persistence.moxy/src/main/java/org/eclipse/persistence/jaxb/JAXBContext.java Show resolved Hide resolved
...ersistence.moxy/src/main/java/org/eclipse/persistence/jaxb/plugins/BeanValidationPlugin.java Show resolved Hide resolved
...java/org/eclipse/persistence/testing/jaxb/beanvalidation/BeanValidationBindingsTestCase.java Outdated Show resolved Hide resolved
@lukasj
Moving MOXy on JPMS to experimental stage
7e7c966 
-integrated jaxb 3.0.2-b01
-removed most refllection calls
-fixed tests to run properly on JDK 11+
-moved jaxb-compiler.sh/cmd on JDK9+ from class-path to module-path
-replaced setAccessible class by trySetAccessible, added FINE logging for cases when set fails

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
fix javadoc build on openjdk11
72ee3e1 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
set min only
621e089 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
address feedback
f8c6cf0 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
javadoc build is fixed
63aecad 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj requested a review from rfelcman May 13, 2021 14:39
rfelcman
rfelcman approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except last two comments

...ence.moxy/src/main/java/org/eclipse/persistence/jaxb/javamodel/reflection/JavaClassImpl.java Outdated Show resolved Hide resolved
bundles/moxy-standalone/src/main/scripts/jaxb-compiler.cmd Outdated Show resolved Hide resolved
@lukasj
feedback
4852ddf 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
avoid dup key
67d67d3 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj merged commit 097df17 into eclipse-ee4j:master May 13, 2021
@lukasj lukasj deleted the moxy-jpmsea branch May 13, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukasj @rfelcman