Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] Minor JSE test failure fixes #1231

Merged
merged 1 commit into from Aug 7, 2021
Merged

[3.0] Minor JSE test failure fixes #1231

merged 1 commit into from Aug 7, 2021

Conversation

dazey3
Copy link
Contributor

@dazey3 dazey3 commented Aug 5, 2021

  1. TestQueryProperties / TestQueryHints - Failing on Oracle
Caused by: java.sql.SQLSyntaxErrorException: ORA-00955: name is already used by an existing object
	at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:447)
	at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
	at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:951)

Failing because drop/create was not used for all EMFs. Not sure why Oracle specifically had issues with this an no other database...

  1. TestConvertResultToBoolean - Failing on DB2 & Oracle
    On Oracle, the return type is BigDecimal and on DB2/Derby, the return type is Integer.

Signed-off-by: Will Dazey dazeydev.3@gmail.com

@dazey3
Minor JSE test failure fixes
365f826 
Signed-off-by: Will Dazey <dazeydev.3@gmail.com>
@dazey3
Copy link
Contributor Author

dazey3 commented Aug 6, 2021

@lukasj Can you review this PR as it is related to #1229

lukasj
lukasj approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 6c146d3 into eclipse-ee4j:3.0 Aug 7, 2021
@dazey3 dazey3 deleted the minorTestFixes_3.0 branch August 9, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dazey3 @lukasj