Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] IdentifiableTypeImpl throws IllegalArgumentException with EmbeddedId and relations - bugfix + unit test - backport from master #1367

Conversation

rfelcman
Copy link
Contributor

Because there are four new objects (java classes) in org.eclipse.persistence.testing.models.jpa.metamodel package MetamodelMetamodelTest.METAMODEL_ALL_TYPES is increased into 56.
These four objects have eights new attributes. This is why MetamodelMetamodelTest.METAMODEL_ALL_ATTRIBUTES_SIZE is increased into 158.

fixes #1228

Signed-off-by: Radek Felcman radek.felcman@oracle.com
(cherry picked from commit 07c80a8)

…and relations - bugfix + unit test (eclipse-ee4j#1355)

* IdentifiableTypeImpl throws IllegalArgumentException with EmbeddedId and relations - bugfix + unit test

Because there are four new objects (java classes) in org.eclipse.persistence.testing.models.jpa.metamodel package MetamodelMetamodelTest.METAMODEL_ALL_TYPES is increased into 56.
These four objects have eights new attributes. This is why MetamodelMetamodelTest.METAMODEL_ALL_ATTRIBUTES_SIZE is increased into 158.

fixes eclipse-ee4j#1228

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
(cherry picked from commit 07c80a8)
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 800b670 into eclipse-ee4j:3.0 Nov 30, 2021
@rfelcman rfelcman deleted the bug_jpa_1228_IdentifiableTypeImplThrowsException_3.0 branch November 30, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants