[master] Fix issue 1504 JSE test failure on Derby pt2 #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test fix was missed in #1534
org.eclipse.persistence.jpa.test.property.TestParameterBinding.testIN_ForceBindJPQLParameters()
This test was failing on Derby because the test is testing the persistence property
eclipselink.jdbc.force-bind-parameters
. With this property set, all parameters are bound as parameters, which is illegal on Derby. I recently changedDB2Platform.shouldBindLiterals
to default to "true", making the literals in the test to now also bind as parameters. This causes a failure on Derby as it is invalid syntax. The test needs updated to respect that this test will fail on DerbyThe property
eclipselink.jdbc.force-bind-parameters
should be deprecated really. The latest propertyeclipselink.jdbc.allow-partial-bind-parameters
is much more comprehensive as it doesn't completely "force" parameter binding and respects platform syntax legality.Signed-off-by: Will Dazey dazeydev.3@gmail.com