Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate eclipselink-testbuild-plugin 0.0.1 (from staging) #1588

Merged
merged 2 commits into from Jul 13, 2022

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Jul 13, 2022

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj requested a review from rfelcman July 13, 2022 11:48
@lukasj lukasj changed the title integrate eclipselink-testbuld-plugin 0.0.1 (from staging) integrate eclipselink-testbuild-plugin 0.0.1 (from staging) Jul 13, 2022
<plugin>
<!-- see https://github.com/lukasj/eclipselink-build-support -->
<groupId>org.eclipse.persistence</groupId>
<artifactId>eclipselink-testbuild-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about registration into pluginManagement in the main project pom.xml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, it would be better to move the plugin away from my "personal" before that

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj merged commit 6c188f4 into eclipse-ee4j:master Jul 13, 2022
@lukasj lukasj deleted the testbuild-plg branch July 13, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants