Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the jpa dependency on json optional #1629

Merged
merged 3 commits into from Aug 4, 2022
Merged

make the jpa dependency on json optional #1629

merged 3 commits into from Aug 4, 2022

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Aug 3, 2022

  • removed unneeded executions from testapps build
  • improved stability of tests on the server
  • cleanup in testapps

@lukasj
cleanup in testapps, improve stability on the server
13ef21a 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
remove/hide not needed parts of the build in testapps
c5e01f9 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
make the jpa dependency on json optional
4e1959d 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj requested a review from rfelcman August 3, 2022 22:44
rfelcman
rfelcman approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit f42def4 into eclipse-ee4j:master Aug 4, 2022
@lukasj lukasj deleted the cln branch August 4, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukasj @rfelcman