Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move advanced tests to testapps #1681

Merged
merged 2 commits into from Sep 6, 2022
Merged

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Aug 28, 2022

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

@lukasj lukasj marked this pull request as ready for review September 6, 2022 12:31
@lukasj lukasj requested a review from rfelcman September 6, 2022 12:31
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<!--Generate multiple jar files required for tests.-->
<plugin>
<groupId>com.soebes.maven.plugins</groupId>
<artifactId>iterator-maven-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe after this change iterator-maven-plugin should be removed from whole project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's more cleanup needed, therefore I prefer to postpone this to the other/followup PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually nosql.test is still using this plugin

@lukasj lukasj force-pushed the advanced branch 2 times, most recently from bb2e397 to 39f6311 Compare September 6, 2022 14:41
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj merged commit dc8ff89 into eclipse-ee4j:master Sep 6, 2022
@lukasj lukasj deleted the advanced branch September 6, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants