Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using https:// for the ECA link in Contribution.md #1802

Merged
merged 1 commit into from Feb 1, 2023
Merged

Using https:// for the ECA link in Contribution.md #1802

merged 1 commit into from Feb 1, 2023

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Feb 1, 2023

No description provided.

rfelcman
rfelcman reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md line 74 should be updated too

@vogella
Copy link
Contributor Author

vogella commented Feb 1, 2023

Thanks @rfelcman for the fast feedback PR updated

rfelcman
rfelcman approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 1df3bb2 into eclipse-ee4j:master Feb 1, 2023
@vogella vogella deleted the https branch February 1, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vogella @rfelcman