[master] fix #1596 Major performance issue in case of many new entities #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of a linear search Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
rfelcman
reviewed
Apr 4, 2023
rfelcman
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Please check and extend tests org.eclipse.persistence.testing.tests.unitofwork.UnregisterUnitOfWorkTest with primaryKeyToNewObjects -> getPrimaryKeyToNewObjects() and
org.eclipse.persistence.testing.tests.unitofwork.DoubleNestedUnitOfWork* and
org.eclipse.persistence.testing.tests.unitofwork.NestedUnitOfWorkDelete*
...persistence.core/src/main/java/org/eclipse/persistence/internal/sessions/UnitOfWorkImpl.java
Outdated
Show resolved
Hide resolved
...persistence.core/src/main/java/org/eclipse/persistence/internal/sessions/UnitOfWorkImpl.java
Show resolved
Hide resolved
- extended tests - updated copyright year - call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
rfelcman
requested changes
Apr 6, 2023
...persistence.core/src/main/java/org/eclipse/persistence/internal/sessions/UnitOfWorkImpl.java
Outdated
Show resolved
Hide resolved
...t/src/it/java/org/eclipse/persistence/testing/tests/unitofwork/UnregisterUnitOfWorkTest.java
Outdated
Show resolved
Hide resolved
- remove list from primaryKeyToNewObjects if it is empty - simplify tests Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com>
|
Thanks! |
Please make another PR manually. Git cherry pick will not work, as 2.7 was built by Ant and master by Maven (different directory structure, huge refator). Class names are same, but locations are different. |
|
@rfelcman Alright, we'll do that. |
rfelcman
pushed a commit
to rfelcman/eclipselink
that referenced
this pull request
Apr 13, 2023
…ities (eclipse-ee4j#1843) * Issue 1596: use a hash-based collection to lookup objects in the cache instead of a linear search * Adjusted source according to review: - extended tests - updated copyright year - call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges - remove list from primaryKeyToNewObjects if it is empty - simplify tests Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com> (cherry picked from commit 76d8274) Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
rfelcman
added a commit
that referenced
this pull request
Apr 17, 2023
#1863) * Issue 1596: use a hash-based collection to lookup objects in the cache instead of a linear search * Adjusted source according to review: - extended tests - updated copyright year - call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges - remove list from primaryKeyToNewObjects if it is empty - simplify tests (cherry picked from commit 76d8274) Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com> Signed-off-by: Radek Felcman <radek.felcman@oracle.com> Co-authored-by: Patrick Schmitt <13404745+zuplyx@users.noreply.github.com>
dtaimanov
pushed a commit
to jmix-framework/eclipselink
that referenced
this pull request
Jan 18, 2024
…ities (eclipse-ee4j#1843) * Issue 1596: use a hash-based collection to lookup objects in the cache instead of a linear search Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com> * Adjusted source according to review: - extended tests - updated copyright year - call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges - remove list from primaryKeyToNewObjects if it is empty - simplify tests Signed-off-by: Patrick Schmitt <Patrick.Schmitt@cpb-software.com> (cherry picked from commit 76d8274)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lookup is performed in a UnitOfWork, eclipselink used to perform a linear search through all new entities. If the UnitOfWork contains many new objects, this becomes a major performance issue, since in the worst case every persisted entity has to be checked and a primary key extraction performed.
By instead maintaining a HashMap of primary key to new objects in the UnitOfWork, the performance impact of a lookup becomes negligible even if there are many persisted entities.
To demonstrate this, I used the UnitTest attached to this comment in the original issue with 10k new entities:
In the original implementation 75% of the execution time is spent in
org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.getObjectFromNewObjects (Class, Object)and there are ~50k calls toorg.eclipse.persistence.internal.descriptors.ObjectBuilder.extractPrimaryKeyFromObject (Object, org.eclipse.persistence.internal.sessions.AbstractSession, boolean):With my new implementation using a HashMap, time spent in
getObjectFromNewObjects (Class, Object)is reduced to 0.1% and no additional primary key extraction is needed: