Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Ant build - MOXy tests fix #1907

Merged
merged 1 commit into from Jul 4, 2023

Conversation

rfelcman
Copy link
Contributor

@rfelcman rfelcman commented Jul 4, 2023

Merge JVM arguments from internal store (antbuild.xml) and outside (passed with -Dadditional.jvmargs=.... command line parameter).
To correctly handle MOXy test execution command like
ant -f antbuild.xml -Dadditional.jvmargs='-javaagent:/usr/local/javaApplications/jacoco-0.8.10/lib/jacocoagent.jar=destfile=/0/0000/jacoco.out,append=true,includes=javax.persistence*:org.eclipse.persistence*,excludes=javax.resource*:org.eclipse.persistence.internal.libraries*,sessionid=lrg,output=file' test-moxy with needed internal -Ddummy2=dummy --add-opens java.base/java.math=ALL-UNNAMED JVM options.

Merge JVM arguments from internal store (antbuild.xml) and outside (passed with '-Dadditional.jvmargs=....' command line parameter).

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
@rfelcman rfelcman merged commit 350d193 into eclipse-ee4j:2.7 Jul 4, 2023
2 of 5 checks passed
@rfelcman rfelcman deleted the moxy_jdk21_test_fix_2.7 branch July 4, 2023 11:53
rfelcman added a commit to rfelcman/eclipselink that referenced this pull request Jul 4, 2023
rfelcman added a commit that referenced this pull request Jul 4, 2023
* Revert "Ant build - MOXy tests fix (#1907)"

This reverts commit 350d193.

* Ant build - MOXy tests fix 2.0
Merge JVM arguments from internal store (antbuild.xml) and outside (passed with '-Dadditional.jvmargs=....' command line parameter).
There was issue with previous fix, that Ant will initialize undefined property automatically during calls like value="${additional.jvmargs}..." into value '${additional.jvmargs}'.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant