[master] Bug 391279: Fix usecase with existing FK mapping #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #233
The original 391279 did not account for the usecase of an existing foreign key mapping on the owning side and instead expected the FK would be added by the @joincolumn. This results in an exception similar to this:
The issue is due to the use of
ObjectBuilder.buildRow(AbstractRecord databaseRow, Object object, AbstractSession session, WriteType writeType)
inOneToManyMapping
. This method callsDatabaseMapping.writeFromObjectIntoRow(Object object, AbstractRecord row, AbstractSession session, WriteType writeType)
, which adds to the given row, causing duplicates.Signed-off-by: Will Dazey dazeydev.3@gmail.com