Update core.test script to allow easier testing against modules #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Tomas-Kraus
reviewed
May 21, 2018
| <path refid="core_test.compile.path"/> | ||
| <path refid="core_test.runtime.only.path"/> | ||
| </path> | ||
| </target> | ||
|
|
||
| <target name="init-test-macro" depends="init"> |
There was a problem hiding this comment.
Is it really necessary to put target around macro? Why not to call it directly?
There was a problem hiding this comment.
Proper dependecies is one point. Other is that for 'clean build' one does not need the macro at all, so this may also improve efficiency of the build in terms of time and memory.
Tomas-Kraus
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes split package between core and core.test and updates travis to use Ant 1.10.2 for the build