#12: provide initial version of top-level pom for EE4J projects #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
parent/pom.xml
Outdated
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>org.eclipse.jakartaee</groupId> |
There was a problem hiding this comment.
Is this something that should be run through the Jakarta EE WG?
The groupId here should match the groupId for future specifications.
There was a problem hiding this comment.
I would say that it should be org.eclipse.ee4j and match groupid for future implementations. Subprojects can override it anyway.
There was a problem hiding this comment.
I agree, org.eclipse.ee4j sounds much better. We should leave the jakarta name out for ee4j projects.
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
|
change gId to |
ivargrimstad
approved these changes
Apr 17, 2018
smillidge
reviewed
Apr 17, 2018
parent/pom.xml
Outdated
| <version>1.0-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
|
|
||
| <name>Jakarta EE Project</name> |
There was a problem hiding this comment.
Good catch! Yes, it should...
smillidge
approved these changes
Apr 17, 2018
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
|
fixed project name in 67d408f |
ivargrimstad
approved these changes
Apr 17, 2018
|
Merged. @lukasj, you can proceed and deploy it to Maven Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com