Implementation of 3.0.0 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add empty impelemntations to new methods implement date changes in ManagedScheduledThreadPoolExecutor
|
@aubi did you sign the commit and is your github account associated with your Eclipse account? |
|
@scottmarlow I will have to fix the commits... I use two mails and accidentally some of the commits are signed with the other mail. |
It causes double thread initialization. The setup/clean is done by the AbstractManagedExecutorService itself.
Transaction is handled by contextSetupProvider.
Call contextSetupProvider.beforeProxyMethod (suspends trans.) before transactionSetupProvider.setup (resets transaction)
Move them from ManagedExecutorServiceImpl and ManagedScheduledExecutorServiceImpl as they will be implemented in the same way.
Specifically MCF.thenApplyAsync, thenCombineAsync, applyToEitherAsync, MSES.cop
breakponchito
force-pushed
the
jakartaee10
branch
from
d72d746
to
a729e8c
Compare
|
@scottmarlow Fixed. Thanks for warning us. |
jamezp
reviewed
May 13, 2022
smillidge
reviewed
May 15, 2022
src/main/java/org/glassfish/enterprise/concurrent/AsynchronousInterceptor.java
Show resolved
Hide resolved
src/main/java/org/glassfish/enterprise/concurrent/internal/ManagedCompletableFuture.java
Show resolved
Hide resolved
arjantijms
reviewed
May 15, 2022
src/main/java/org/glassfish/enterprise/concurrent/ManagedThreadFactoryImpl.java
Show resolved
Hide resolved
Remove -SNAPSHOT
smillidge
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Concurrency API 3.0.0
Some of the functionality required by Concurrency is implemented inside the server. For Payara, the changes are in the feature branch payara6-concurrency-3.0-upgrade. TCK was tested using Concurrency TCK Runner.
The implementation (both RI and Payara) run TCK with serveral exceptions -- PRs with fixes are created for API/TCK repository and TCK Challenges are now being filed now. The list is in TCK runner's tck-suite.xml.
TCK Tests Result:
Tests run: 150, Failures: 0, Errors: 0, Skipped: 0