Issue #475 Changed default error handling of HK2 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatej
force-pushed
the
fixed-475-initialization-error-handling
branch
2 times, most recently
from
18a5890
to
9b81765
Compare
|
@dmatej you have some conflict in the PR can you resolve them |
dmatej
force-pushed
the
fixed-475-initialization-error-handling
branch
from
9b81765
to
7b72bf7
Compare
smillidge
approved these changes
Oct 5, 2019
hk2-api/src/main/java/org/glassfish/hk2/utilities/IgnoringErrorService.java
Outdated
Show resolved
Hide resolved
dmatej
force-pushed
the
fixed-475-initialization-error-handling
branch
from
7b72bf7
to
c1d6470
Compare
- originally the HK2 ignored all errors, so when the DynamicConfigurationService was not accessible because of classloading issues (on JDK11), it ended up with NPE without any usabe cause - now by default throws out any "reify" exception that can occur until it is configured to use another ErrorService implementation - original behavior can be reached by configuring the IgnoringErrorService, but only after successful serviceloader initialization (StaticModulesRegistry now does it) - initialization is successful and the service is configured OR you catch an exception, but you should not get unconfigured failing locator. - tests were reviewed and fixed, because sometimes they tested states that could not be reached without swallowing exceptions. - one more test for the new implementation has been added. Signed-off-by: David Matejcek <dmatej@seznam.cz>
dmatej
force-pushed
the
fixed-475-initialization-error-handling
branch
from
c1d6470
to
0bab62c
Compare
am-houtkooper
pushed a commit
to am-houtkooper/glassfish-hk2
that referenced
this pull request
Oct 24, 2019
…ion-error-handling Issue eclipse-ee4j#475 Changed default error handling of HK2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally the HK2 ignored all errors, so when the DynamicConfigurationService
was not accessible because of classloading issues (on JDK11), it ended up
with NPE without any usabe cause
now by default throws out any "reify" exception that can occur
until it is configured to use another ErrorService implementation
original behavior can be reached by configuring the IgnoringErrorService,
but only after successful serviceloader initialization (StaticModulesRegistry
now does it)
initialization is successful and the service is configured
OR you catch an exception, but you should not get unconfigured failing locator.
tests were reviewed and fixed, because sometimes they tested states that
could not be reached without swallowing exceptions.
one more test for the new implementation has been added.