Fix optional injection bugs #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smillidge
requested changes
Aug 11, 2020
hk2-locator/src/test/java/org/glassfish/hk2/tests/locator/optional/NamedOptionalInjection.java
Outdated
Show resolved
Hide resolved
BCSol
changed the title
|
I found some more related bugs, which I wrote test for and bundled them here together. |
|
This is failing Jenkins build |
tbh, I am a bit confused as to why. The error log seems to indicate, that |
|
IsEmpty is JDK 11 only and we need to support JDK 8 fir Jakarta EE 9 |
OptionalActiveDescriptor does seem to use @nAmed injection for it's wrapped value. As a consequence both unnamed and other named bindings for the same type are/may be injected when the actual binding is missing/present. Signed-off-by: Balthasar Schüss <mail@bschuess.dev>
Signed-off-by: Balthasar Schüss <mail@bschuess.dev>
Trying to inject Optional<Optional<String>> one might expect the following: bound literal String -> expected Optional<Optional<String> -> actual Optional<Optional.empty> bound Optional<Optional<String> -> expected Optional<Optional<String>> -> actual Optional<Optional<Optional>>> Furthermore, one might expect that more specific bindings take precedence over less specific bindings, that is also not the case It is true that nested Optionals is not a common use case, but the precedence should be implemented either way. Signed-off-by: Balthasar Schüss <mail@bschuess.dev>
If a guice service is injected as optional into a hk2 service. Guice services are never injected and Optional is always empty. Signed-off-by: Balthasar Schüss <mail@bschuess.dev>
Signed-off-by: Balthasar Schüss <mail@bschuess.dev>
smillidge
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests and fixes for:
OptionalActiveDescriptor fails to inject @nAmed optional values, because (name) qualifiers are not propagated for the retrieval of the wrapped value. As a consequence any bound instance (unnamed, with same name, or other name) may be injected.
This is a treacherous bug, in particular when injecting configuration parameters and migrating from previous versions.
Trying to inject Optional<Optional> one might expect the following:
Furthermore, one might expect that more specific bindings take precedence over less specific bindings, that is also not the case.
It is true that nested Optionals are not a common use case, but the precedence should be implemented either way.
Trying to inject Guice services as Optional into hk2 services always causes the optional to be empty.