Changes to pass the DI TCK #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Coustick <jonathan.coustick@payara.fish>
Pandrex247
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Not a field of expertise of mine, but the tests pass and the TCK passes.
I spoke to you in Teams about the changes made to NegativeMethodTest#testStaticMethod and NegativeFieldTest#testStaticField. For transparency: In short, those tests now check that nothing gets injected rather than checking an exception gets thrown when attempting to inject
arjantijms
reviewed
Mar 31, 2021
|
@smillidge From the Jersey perspective, I'd say the change is ok, since what it threw the exception before, now works. But we would need to have the HK2 (perhaps staging) at hand to run the tests to be sure. |
|
I have built HK2 with this PR and internal Jersey tests (not TCK) passed with this HK2 change. |
|
Thanks @jansupol for the extra testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes HK2 injection order to match that required by TCK.
It also changes behaviour when encountering static injection to ignore it rather than throwing an error as that prevents the TCK from running. With this change HK2 now passes the DI TCK, a runner for which is now included in the test modules.