Mapped JTA DS: Refactoring

Cleanup, added javadoc, moved a helper class to the test tools module

appserver/tests/application/src/test/java/org/glassfish/main/test/setup/DeploymentAware.java → appserver/itest-tools/src/main/java/org/glassfish/main/itest/tools/setup/DeploymentAware.java

@@ -13,7 +13,7 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  */
-package org.glassfish.main.test.setup;
+package org.glassfish.main.itest.tools.setup;
 
 import static java.lang.System.Logger.Level.INFO;
 
@@ -24,7 +24,7 @@
 import org.jboss.shrinkwrap.api.spec.WebArchive;
 
 /**
- *
+ * Adds some helper methods as default interface methods related to creating deployments in tests.
  * @author Ondro Mihalyi
  */
 public interface DeploymentAware {

appserver/tests/application/src/test/java/org/glassfish/main/test/app/persistence/resourceref/JtaDataSourceResourceRefTest.java

@@ -34,9 +34,9 @@
 
 import org.glassfish.main.itest.tools.asadmin.Asadmin;
 import org.glassfish.main.itest.tools.asadmin.AsadminResult;
+import org.glassfish.main.itest.tools.setup.DeploymentAware;
 import org.glassfish.main.test.app.persistence.resourceref.webapp.ResourceRefApplication;
 import org.glassfish.main.test.app.persistence.resourceref.webapp.ResourceRefResource;
-import org.glassfish.main.test.setup.DeploymentAware;
 
 /**
  * Tests that JTA datasource in persistence.xml can be a resource reference

appserver/tests/application/src/test/java/org/glassfish/main/test/app/persistence/transform/ClassTransformerEjbWebAppTest.java

@@ -31,8 +31,6 @@
 import static org.glassfish.main.itest.tools.asadmin.AsadminResultMatcher.asadminOK;
 import static org.hamcrest.MatcherAssert.assertThat;
 
-
-
 /**
  * Tests bytecode preprocessing in ASURLClassLoader.
  */

appserver/tests/application/src/test/java/org/glassfish/main/test/app/persistence/transform/ClassTransformerTestBase.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023,2024 Contributors to the Eclipse Foundation.
+ * Copyright (c) 2023 Contributors to the Eclipse Foundation.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0, which is available at
@@ -38,7 +38,6 @@
 
 import static org.glassfish.main.itest.tools.GlassFishTestEnvironment.getAsadmin;
 
-
 public class ClassTransformerTestBase {
 
     private static final String PROVIDER_FILE_NAME = "provider.jar";

appserver/tests/application/src/test/java/org/glassfish/main/test/app/persistence/transform/ClassTransformerWebAppTest.java

@@ -21,6 +21,8 @@
 import java.net.HttpURLConnection;
 import java.nio.file.Files;
 
+import org.glassfish.main.test.app.persistence.transform.webapp.ClassTransformerApplication;
+import org.glassfish.main.test.app.persistence.transform.webapp.ClassTransformerResource;
 import org.jboss.shrinkwrap.api.ShrinkWrap;
 import org.jboss.shrinkwrap.api.asset.EmptyAsset;
 import org.jboss.shrinkwrap.api.spec.WebArchive;
@@ -33,9 +35,6 @@
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.MatcherAssert.assertThat;
 
-import org.glassfish.main.test.app.persistence.transform.webapp.ClassTransformerApplication;
-import org.glassfish.main.test.app.persistence.transform.webapp.ClassTransformerResource;
-
 /**
  * Tests bytecode preprocessing in WebappClassLoader.
  */

appserver/tests/application/src/test/java/org/glassfish/main/test/app/synchronize/SynchronizeStandaloneInstanceTest.java

@@ -32,7 +32,6 @@
 import static org.glassfish.main.itest.tools.asadmin.AsadminResultMatcher.asadminOK;
 import static org.hamcrest.MatcherAssert.assertThat;
 
-
 /**
  * Tests synchronization between DAS and standalone instance.
  */
@@ -58,6 +57,7 @@ public static void createInstance() {
         try {
             assertThat(ASADMIN.exec("create-instance", "--node", "localhost-domain1", INSTANCE_NAME), asadminOK());
         } catch (AssertionError e) {
+            // cleanup on error, the instance is not going to be deleted otherwise
             ASADMIN.exec("delete-instance", INSTANCE_NAME);
             throw e;
         }