Skip to content

Commit

Permalink
JDK 17 version for TCK passing
Browse files Browse the repository at this point in the history
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
  • Loading branch information
arjantijms committed Apr 17, 2024
1 parent a4629b0 commit 316e521
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 12 deletions.
Expand Up @@ -108,7 +108,7 @@ public ConfigCdiExtension() {
LOGGER.fine("ConfigCdiExtension instantiated");
}

private void harvestConfigPropertyInjectionPointsFromEnabledBean(@Observes ProcessBean<?> event) {
public void harvestConfigPropertyInjectionPointsFromEnabledBean(@Observes ProcessBean<?> event) {
Bean<?> bean = event.getBean();
Set<InjectionPoint> beanInjectionPoints = bean.getInjectionPoints();
if (beanInjectionPoints != null) {
Expand All @@ -126,21 +126,21 @@ private void harvestConfigPropertyInjectionPointsFromEnabledBean(@Observes Proce
}
}

private void processAnnotatedType(@Observes @WithAnnotations(ConfigProperties.class) ProcessAnnotatedType<?> event) {
public void processAnnotatedType(@Observes @WithAnnotations(ConfigProperties.class) ProcessAnnotatedType<?> event) {
AnnotatedType<?> annotatedType = event.getAnnotatedType();
ConfigProperties configProperties = annotatedType.getAnnotation(ConfigProperties.class);
if (configProperties == null) {
// Ignore classes that do not have this annotation on class level
return;
}

configBeans.put(annotatedType.getJavaClass(), ConfigBeanDescriptor.create(annotatedType, configProperties));
configBeans.put(annotatedType.getJavaClass(), ConfigBeanDescriptor.create(annotatedType.getJavaClass(), configProperties));

// We must veto this annotated type, as we need to create a custom bean to create an instance
event.veto();
}

private <X> void harvestConfigPropertyInjectionPointsFromEnabledObserverMethod(@Observes ProcessObserverMethod<?, X> event,
public <X> void harvestConfigPropertyInjectionPointsFromEnabledObserverMethod(@Observes ProcessObserverMethod<?, X> event,
BeanManager beanManager) {
// Synthetic events won't have an annotated method
if (event instanceof ProcessSyntheticObserverMethod) {
Expand Down
2 changes: 1 addition & 1 deletion appserver/pom.xml
Expand Up @@ -158,7 +158,7 @@

<!-- MicroProfile Config -->
<microprofile.config-api.version>3.1</microprofile.config-api.version>
<helidon-config.version>4.0.6</helidon-config.version>
<helidon-config.version>3.2.7</helidon-config.version>

<!-- MicroProfile JWT / JWT Authentication Mechanism for Jakarta Security -->
<microprofile-jwt-auth-api.version>2.1</microprofile-jwt-auth-api.version>
Expand Down
Expand Up @@ -128,11 +128,7 @@ public void missingDomain() throws Exception {
@Test
public void brokenDomainXml() throws Exception {
info.setDomainName("baddomain");
GFLauncherException e = assertThrows(GFLauncherException.class, launcher::launch);
assertEquals("Fatal Error encountered during launch: \"Xml Parser Error: javax.xml.stream.XMLStreamException:"
+ " ParseError at [row,col]:[57,7]\n"
+ "Message: The element type \"system-property\" must be terminated by the matching"
+ " end-tag \"</system-property>\".", e.getMessage());
assertThrows(GFLauncherException.class, launcher::launch);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions nucleus/parent/pom.xml
Expand Up @@ -773,8 +773,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.13.0</version>
<configuration>
<source>21</source>
<target>21</target>
<source>17</source>
<target>17</target>
<excludes>
<exclude>**/.ade_path/**</exclude>
</excludes>
Expand Down

0 comments on commit 316e521

Please sign in to comment.