Fixed missing resource bundle warning in logs

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
eclipse-ee4j · Nov 13, 2023 · 5170f80 · 5170f80
1 parent 7d191e3
commit 5170f80
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/...core-ee/src/main/java/com/sun/enterprise/security/ee/authorize/cache/PermissionCache.java b/...core-ee/src/main/java/com/sun/enterprise/security/ee/authorize/cache/PermissionCache.java
@@ -1,4 +1,5 @@
 /*
+ * Copyright (c) 2023 Contributors to the Eclipse Foundation
  * Copyright (c) 1997, 2020 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
@@ -16,6 +17,12 @@
 
 package com.sun.enterprise.security.ee.authorize.cache;
 
+import com.sun.enterprise.security.common.AppservAccessController;
+import com.sun.enterprise.security.ee.authorize.cache.CachedPermissionImpl.Epoch;
+import com.sun.logging.LogDomains;
+
+import jakarta.security.jacc.PolicyContext;
+
 import java.security.AllPermission;
 import java.security.CodeSource;
 import java.security.Permission;
@@ -30,11 +37,6 @@
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import com.sun.enterprise.security.common.AppservAccessController;
-import com.sun.enterprise.security.ee.authorize.cache.CachedPermissionImpl.Epoch;
-import com.sun.logging.LogDomains;
-
-import jakarta.security.jacc.PolicyContext;
 
 /**
  * This class is
@@ -44,22 +46,22 @@
 
 public class PermissionCache extends Object {
 
-    private static Logger _logger = LogDomains.getLogger(PermissionCache.class, LogDomains.SECURITY_LOGGER);
+    private static final Logger LOG = LogDomains.getLogger(PermissionCache.class, LogDomains.SECURITY_LOGGER, false);
     private static Policy policy = Policy.getPolicy();
     private static AllPermission allPermission = new AllPermission();
 
     private Permissions cache;
     private CodeSource codesource;
-    private Permission[] protoPerms;
+    private final Permission[] protoPerms;
     private Class[] classes;
-    private String name;
-    private String pcID;
+    private final String name;
+    private final String pcID;
     private final Integer factoryKey;
     private volatile int epoch;
     private volatile boolean loading;
-    private ReadWriteLock rwLock;
-    private Lock rLock;
-    private Lock wLock;
+    private final ReadWriteLock rwLock;
+    private final Lock rLock;
+    private final Lock wLock;
 
     /*
      * USE OF THIS CONSTRUCTOR WITH IS DISCOURAGED PLEASE USE THE Permission (object) based CONSTRUCTOR.
@@ -219,7 +221,7 @@ private boolean checkCache(Permission p, Epoch e) {
                 setPc = true;
             }
         } catch (Exception ex) {
-            _logger.log(Level.SEVERE, "JACC: Unexpected security exception on access decision", ex);
+            LOG.log(Level.SEVERE, "JACC: Unexpected security exception on access decision", ex);
             return false;
         }
 
@@ -231,14 +233,14 @@ private boolean checkCache(Permission p, Epoch e) {
 
             pc = policy.getPermissions(this.codesource);
         } catch (Exception ex) {
-            _logger.log(Level.SEVERE, "JACC: Unexpected security exception on access decision", ex);
+            LOG.log(Level.SEVERE, "JACC: Unexpected security exception on access decision", ex);
             return false;
         } finally {
             if (setPc) {
                 try {
                     setPolicyContextID(oldpcID);
                 } catch (Exception ex) {
-                    _logger.log(Level.SEVERE, "JACC: Unexpected security exception on access decision", ex);
+                    LOG.log(Level.SEVERE, "JACC: Unexpected security exception on access decision", ex);
                     return false;
                 }
             }