Reflecting BalusC review - finals, better constructor

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
eclipse-ee4j · Jan 16, 2023 · 7b70597 · 7b70597
1 parent c554b43
commit 7b70597
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/appserver/web/war-util/src/main/java/org/glassfish/web/loader/RepositoryManager.java b/appserver/web/war-util/src/main/java/org/glassfish/web/loader/RepositoryManager.java
@@ -79,8 +79,8 @@ public void close() throws IOException {
 
     private static class Repository {
 
-        public String name;
-        public File directory;
+        public final String name;
+        public final File directory;
 
         Repository(String name, File directory) {
             this.name = name;
@@ -96,8 +96,8 @@ public String toString() {
 
     static class RepositoryResource {
 
-        public String name;
-        public File file;
+        public final String name;
+        public final File file;
 
         RepositoryResource(String name, File file) {
             this.name = name;

diff --git a/appserver/web/war-util/src/main/java/org/glassfish/web/loader/ResourceEntry.java b/appserver/web/war-util/src/main/java/org/glassfish/web/loader/ResourceEntry.java
@@ -98,8 +98,7 @@ public class ResourceEntry {
      * @param url resource location
      */
     ResourceEntry(URL url) {
-        codeBase = url;
-        source = url;
+        this(url, url);
     }