Skip to content

Commit

Permalink
Revert change in isApplicationEnabled if appName is null
Browse files Browse the repository at this point in the history
appName is null by default in concurrent tasks because app context isn't propagated.
This needs to be fixed before appName can be considered not null.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
  • Loading branch information
OndroMih committed Aug 14, 2023
1 parent cf0c624 commit 803fe51
Showing 1 changed file with 6 additions and 1 deletion.
Expand Up @@ -250,7 +250,12 @@ private ComponentInvocation getSavedInvocation() {
*/
private boolean isApplicationEnabled(String appId) {
if (appId == null) {
return false;
/* FIXME: appId is null in concurrent tasks because app context isn't propagated
and is empty by default.
This should be fixed: either propagate an application context if there's no current context,
or set up a proper app context when the concurrent task is submitted.
*/
return true;
}
Application app = applications.getApplication(appId);
if (app != null) {
Expand Down

0 comments on commit 803fe51

Please sign in to comment.