The stop method replaced by close, which is standard.

- Also removed the condition about starting.
- There is several reported issues related to the cleanup.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

appserver/web/war-util/src/main/java/org/glassfish/web/loader/WebappClassLoader.java

@@ -1522,19 +1522,16 @@ public boolean isStarted() {
     @Override
     public void preDestroy() {
         try {
-            stop();
+            close();
         } catch (Exception e) {
             throw new IllegalStateException("There were issues with closing " + this, e);
         }
     }
 
-    /**
-     * Stop the class loader.
-     */
-    public void stop() throws IOException {
-        if (!started) {
-            return;
-        }
+
+    @Override
+    public void close() throws IOException {
+        LOG.log(DEBUG, "close()");
 
         // Clearing references should be done before setting started to
         // false, due to possible side effects.
@@ -1551,7 +1548,7 @@ public void stop() throws IOException {
         }
 
         // FIXME: close is called twice = unclear dependencies and order.
-        close();
+        super.close();
 
         started = false;
 
@@ -1573,7 +1570,7 @@ public void stop() throws IOException {
         }
 
         try {
-            close();
+            super.close();
         } catch (Exception e) {
             // ignore
         }

appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java

@@ -699,7 +699,7 @@ public void stop() throws LifecycleException {
      */
     public void stopNestedClassLoader() throws LifecycleException {
         try {
-            classLoader.stop();
+            classLoader.close();
         } catch (Exception e) {
             throw new LifecycleException(e);
         }