Make methods static

eclipse-ee4j · Dec 21, 2022 · 9e0598e · 9e0598e
1 parent d63fb85
commit 9e0598e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContextValve.java b/appserver/web/web-core/src/main/java/org/apache/catalina/core/StandardContextValve.java
@@ -241,7 +241,7 @@ private void log(String message, Throwable t) {
      * @param path to be normalized
      * @return normalized path or null
      */
-    protected String normalize(String path) {
+    protected static String normalize(String path) {
         if (path == null) {
             return null;
         }
@@ -292,7 +292,7 @@ protected String normalize(String path) {
      * @param path to be normalized
      * @return normalized path
      */
-    private String evaluateNormalizedPathWithSinglePoint(String path) {
+    private static String evaluateNormalizedPathWithSinglePoint(String path) {
         // Resolve occurrences of "/./" in the normalized path
         while (true) {
             int idx = path.indexOf("/./");

diff --git a/appserver/web/web-core/src/test/java/org/apache/catalina/core/StandardContextValveTest.java b/appserver/web/web-core/src/test/java/org/apache/catalina/core/StandardContextValveTest.java
@@ -82,13 +82,13 @@ public void normalizeURLTest() {
         String path2 = "/app/./some/./something/./my.jsp";
         String path3 = "./my.jsp";
 
-        String result = standardContextValve.normalize(path1);
+        String result = StandardContextValve.normalize(path1);
         assertEquals("/my.jsp", result);
 
-        result = standardContextValve.normalize(path2);
+        result = StandardContextValve.normalize(path2);
         assertEquals("/app/some/something/my.jsp", result);
 
-        result = standardContextValve.normalize(path3);
+        result = StandardContextValve.normalize(path3);
         assertEquals("/my.jsp", result);
     }
-}
+}