Fixes failure of deployment of test-faces23-websocket in Faces TCK

- It is just a replacement of for i loops by enhanced loops.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

appserver/web/web-core/src/main/java/org/apache/catalina/core/ContainerBase.java

@@ -1252,22 +1252,22 @@ public synchronized void stop() throws LifecycleException {
         }
 
         // Stop our child containers, if any
-        Container children[] = findChildren();
-        for (int i = 0; i < children.length; i++) {
-            if (children[i] instanceof Lifecycle) {
+        Container[] children = findChildren();
+        for (Container child : children) {
+            if (child instanceof Lifecycle) {
                 try {
-                    ((Lifecycle) children[i]).stop();
+                    ((Lifecycle) child).stop();
                 } catch (Throwable t) {
-                    String msg = MessageFormat.format(rb.getString(LogFacade.ERROR_STOPPING_CONTAINER), children[i]);
+                    String msg = MessageFormat.format(rb.getString(LogFacade.ERROR_STOPPING_CONTAINER), child);
                     log.log(Level.SEVERE, msg, t);
                 }
             }
         }
 
         // Remove children - so next start can work
         children = findChildren();
-        for (int i = 0; i < children.length; i++) {
-            removeChild(children[i]);
+        for (Container child : children) {
+            removeChild(child);
         }
 
         // Stop our subordinate components, if any
@@ -1499,8 +1499,8 @@ public void fireContainerEvent(String type, Object data) {
         }
 
         ContainerEvent event = new ContainerEvent(this, type, data);
-        for (int i = 0; i < list.length; i++) {
-            list[i].containerEvent(event);
+        for (ContainerListener listener : list) {
+            listener.containerEvent(event);
         }
     }
 
@@ -1511,17 +1511,17 @@ public void fireContainerEvent(String type, Object data) {
     protected void startChildren() {
 
         Container children[] = findChildren();
-        for (int i = 0; i < children.length; i++) {
-            if (children[i] instanceof Lifecycle) {
+        for (Container child : children) {
+            if (child instanceof Lifecycle) {
                 try {
-                    ((Lifecycle) children[i]).start();
+                    ((Lifecycle) child).start();
                 } catch (Throwable t) {
-                    String msg = MessageFormat.format(rb.getString(LogFacade.CONTAINER_NOT_STARTED_EXCEPTION), children[i]);
+                    String msg = MessageFormat.format(rb.getString(LogFacade.CONTAINER_NOT_STARTED_EXCEPTION), child);
                     log.log(Level.SEVERE, msg, t);
-                    if (children[i] instanceof Context) {
-                        ((Context) children[i]).setAvailable(false);
-                    } else if (children[i] instanceof Wrapper) {
-                        ((Wrapper) children[i]).setAvailable(Long.MAX_VALUE);
+                    if (child instanceof Context) {
+                        ((Context) child).setAvailable(false);
+                    } else if (child instanceof Wrapper) {
+                        ((Wrapper) child).setAvailable(Long.MAX_VALUE);
                     }
                 }
             }
@@ -1761,9 +1761,9 @@ protected void processChildren(Container container, ClassLoader cl) {
                 Thread.currentThread().setContextClassLoader(cl);
             }
             Container[] children = container.findChildren();
-            for (int i = 0; i < children.length; i++) {
-                if (children[i].getBackgroundProcessorDelay() <= 0) {
-                    processChildren(children[i], cl);
+            for (Container child : children) {
+                if (child.getBackgroundProcessorDelay() <= 0) {
+                    processChildren(child, cl);
                 }
             }
         }