Fix admingui has some unhandled messages

Signed-off-by: kaido207 <kaido.hiroki@fujitsu.com>
eclipse-ee4j · Oct 31, 2023 · b56e762 · b56e762
1 parent 50b6842
commit b56e762
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 15 deletions.
diff --git a/appserver/admingui/common/src/main/java/org/glassfish/admingui/common/util/RestResponse.java b/appserver/admingui/common/src/main/java/org/glassfish/admingui/common/util/RestResponse.java
@@ -205,9 +205,7 @@ public Map<String, Object> getResponse() {
                 // Decode JSON
                 result.put("data", JSONUtil.jsonToJava(responseBody));
             } else {
-                // Unsupported Response Format!
-                System.out.println("Unsupported Response Format: '"
-                        + contentType + "'!");
+                Logger.getLogger(RestResponse.class.getName()).log(Level.WARNING, "Unsupported Response Format: '" + contentType + "'!");
             }
         }
 

diff --git a/appserver/admingui/common/src/main/java/org/glassfish/admingui/common/util/RestUtil.java b/appserver/admingui/common/src/main/java/org/glassfish/admingui/common/util/RestUtil.java
@@ -543,9 +543,6 @@ protected static MultivaluedMap buildMultivalueMap(Map<String, Object> payload)
             } else {
                 // formData.putSingle(key, (value != null) ? value.toString() : value);
                 try {
-                    if (key.equals("availabilityEnabled")) {
-                        System.out.println("================== availabilityEnabled  skipped ");
-                    }
                     formData.putSingle(key, value);
                 } catch (ClassCastException ex) {
                     Logger logger = GuiUtil.getLogger();

diff --git a/appserver/admingui/core/src/main/java/org/glassfish/admingui/handlers/TableHandlers.java b/appserver/admingui/core/src/main/java/org/glassfish/admingui/handlers/TableHandlers.java
@@ -207,8 +207,7 @@ public static void getAllSingleMapRows(HandlerContext handlerCtx) {
         try {
             handlerCtx.setOutputValue("Rows", data.get(0));
         } catch (Exception ex) {
-            // TODO alert user, log exception
-            System.out.println("!!!! getAllSingleMapRows() Throws Exception: " + ex.toString());
+            GuiUtil.prepareException(handlerCtx, ex);
         }
 
     }

diff --git a/appserver/admingui/jms-plugin/src/main/java/org/glassfish/admingui/plugin/jms/JMXUtil.java b/appserver/admingui/jms-plugin/src/main/java/org/glassfish/admingui/plugin/jms/JMXUtil.java
@@ -51,8 +51,7 @@ public static Object invoke(String objectName, String operationName, Object[] pa
             Object result = invoke(new ObjectName(objectName), operationName, params, signature);
             return result;
         } catch (javax.management.MalformedObjectNameException ex) {
-            System.out.println("MalformedObjectNameException: " + objectName);
-            throw new RuntimeException(ex);
+            throw new RuntimeException(objectName + " is MalformedObjectName.", ex);
         }
     }
 
@@ -90,8 +89,7 @@ public static void setAttribute(String objectName, Attribute attributeName) {
         try {
             setAttribute(new ObjectName(objectName), attributeName);
         } catch (javax.management.MalformedObjectNameException ex) {
-            System.out.println("MalformedObjectNameException: " + objectName);
-            throw new RuntimeException(ex);
+            throw new RuntimeException(objectName + " is MalformedObjectName.", ex);
         }
     }
 

diff --git a/...rver/admingui/jms-plugin/src/main/java/org/glassfish/admingui/plugin/jms/JmsHandlers.java b/...rver/admingui/jms-plugin/src/main/java/org/glassfish/admingui/plugin/jms/JmsHandlers.java
@@ -215,7 +215,6 @@ public static void getPhysicalDestinations(HandlerContext handlerCtx) {
             }
 
         } catch (Exception ex) {
-            System.out.println("invoke:   " + OBJECT_DEST_MGR + ", method  =  " + OP_LIST_DESTINATIONS);
             GuiUtil.handleException(handlerCtx, ex);
         }
         handlerCtx.setOutputValue("result", result);

diff --git a/...ngui/plugin-service/src/main/java/org/glassfish/admingui/plugin/ConsolePluginService.java b/...ngui/plugin-service/src/main/java/org/glassfish/admingui/plugin/ConsolePluginService.java
@@ -330,8 +330,7 @@ public Map<String, List<URL>> getResources(String name) {
                     } catch (Exception ex) {
                         // Ignore b/c this should not ever happen, we're not
                         // changing the URL
-                        System.out.println(
-                                "ConsolePluginService: URL Copy Failed!");
+                        logger.log(Level.INFO, "ConsolePluginService: URL Copy Failed!");
                     }
                 }