Skip to content

Commit

Permalink
Fixing TCK deadlock
Browse files Browse the repository at this point in the history
- TCK authentication tests ended in deadlock, because the TCK client steals
  logging.properties from the server (wrong idea, 3 JVMs using same
  file - server.log).
  It is because GlassFishLogHandler redirects standard output streams to the
  server.log file, then SimpleLogHandler uses new streams, which situation
  leads to a deadlock.
- GJULE LogManager prevents that by saving original streams on startup, so
  whatever happens later, it still has original values available. JUL doesn't
  have this mechanism.
- So in this commit I am just switching the order, so SimpleLogHandler is
  configured first with original values.
- However, this commit doesn't fix the issue where TCK steals server's cfg file.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
  • Loading branch information
dmatej committed Sep 15, 2022
1 parent a7368ad commit e71dbf3
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
# Handler settings

handlers=\
org.glassfish.main.jul.handler.GlassFishLogHandler,\
org.glassfish.main.jul.handler.SimpleLogHandler,\
org.glassfish.main.jul.handler.GlassFishLogHandler,\
org.glassfish.main.jul.handler.SyslogHandler

org.glassfish.main.jul.handler.GlassFishLogHandler.buffer.capacity=10000
Expand Down

0 comments on commit e71dbf3

Please sign in to comment.