Fixes #22927 removed Jakarta Management API from GlassFish 6.0.0 #22953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h 6.0.0 Signed-off-by: smillidge <steve.millidge@payara.fish>
hs536
approved these changes
Apr 6, 2020
hs536
requested changes
Apr 6, 2020
There was a problem hiding this comment.
3 more files need to be modified for the build to succeed.
# git branch
* 22927
# find . -name "pom.xml" |xargs grep "mejb"
./appserver/extras/embedded/all/pom.xml: <artifactId>mejb-frag</artifactId>
./appserver/extras/embedded/shell/glassfish-embedded-static-shell/pom.xml: <artifactId>mejb-frag</artifactId>
./appserver/featuresets/glassfish/pom.xml: <artifactId>mejb</artifactId>
Signed-off-by: smillidge <steve.millidge@payara.fish>
|
@hs536 I've corrected the build. I hate it when my local maven repo has the snapshot artifact so I don't catch build errors. |
hs536
approved these changes
Apr 20, 2020
|
Resolved merge conflict, will merge this in now. |
dmatej
added a commit
to dmatej/glassfish
that referenced
this pull request
Jan 15, 2022
…rta.management.j2ee-api removal - reverted some changes from the previous commit - removed tests depending on the j2ee-api jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes Quick Look Tests
Signed-off-by: smillidge steve.millidge@payara.fish