Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of SentinelInputStream #24376

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

ctabin
Copy link
Contributor

@ctabin ctabin commented Apr 11, 2023

As per discussed here, complete removal of SentinelInputStream and other related internal classes.

@dmatej dmatej added this to the 7.0.4 milestone Apr 12, 2023
@ctabin ctabin changed the title Removal of SentinalInputStream Removal of SentinelInputStream Apr 12, 2023
@ctabin
Copy link
Contributor Author

ctabin commented Apr 14, 2023

@dmatej Do you know how I could re-run the eclipsefdn/eca check ? I have completed the form several times but the job state doesn't change... Thanks !

@avpinchuk
Copy link
Contributor

@ctabin, maybe try to to edit something in the description and save it again?

@ctabin
Copy link
Contributor Author

ctabin commented Apr 14, 2023

Jenkins test please

@ctabin
Copy link
Contributor Author

ctabin commented Apr 14, 2023

@dmatej Unfortunately, it doesn't help :-/ I'll amend my commit an push force...

@dmatej
Copy link
Contributor

dmatej commented Apr 14, 2023

I will rerun that, I already tried, but it was stuck somehow yesterday or on Wednesday.

Improved ClusterITest - don't remove instances and logs if it failed.
@dmatej
Copy link
Contributor

dmatej commented Apr 14, 2023

Then we have to create an issue on gitlab...

@avpinchuk
Copy link
Contributor

avpinchuk commented Apr 14, 2023

@dmatej, on Wed build works with some ant tests failed randomly by timeout after 1h. Yesterday build process wait on scanning project phase and failed after 6h timeout...

@dmatej
Copy link
Contributor

dmatej commented Apr 14, 2023

@dmatej, on Wed build works with some ant tests failed randomly by timeout after 1h. Yesterday build process wait on scanning project phase and failed after 6h timeout...

There were some issues since friday, on tuesday it worked again, but I forgot to ask about the ECA issue.
Btw yesterday something broke again ... https://www.eclipsestatus.io/

Seems no related issue to ECA at this moment ... https://www.eclipsestatus.io/ ... I will create one.

EDIT: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2961

@dmatej
Copy link
Contributor

dmatej commented Apr 14, 2023

try {
ccf.close();
} catch(IOException ioe) {
_logger.log(Level.WARNING, "error.closing.connector.classloader", ioe);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this key doesn't exist anywhere ... you can just write an english message what failed, ie. Closing of the Connector Class Finder failed.

@arjantijms arjantijms merged commit 65b65ce into eclipse-ee4j:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants