Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.sun.enterprise.util.ProcessExecutor #24453

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

mz1999
Copy link
Contributor

@mz1999 mz1999 commented Jun 8, 2023

Replaced ProcessExecutor with ProcessManager and removed ProcessExecutor as suggested in the issue.

ProcessExecutor redirects standard output and standard error to files, while ProcessManager stores them in memory, so ProcessManager.getStdout() and ProcessExecutor.getLastExecutionOutput are equivalent, and ProcessManager.getStderr() and ProcessExecutor.getLastExecutionError are equivalent.

ProcessExecutor has a default timeout, so when replacing with ProcessManager, you need to explicitly set the timeout.

@dmatej dmatej added this to the 7.0.6 milestone Jun 8, 2023
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! wow!

@arjantijms arjantijms merged commit 087b911 into eclipse-ee4j:master Jun 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants