Using glassfishbuild-maven-plugin 4.0.0 + fixes #24605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Sep 25, 2023
dmatej
commented
- Reviewed all assemblies and custom lifecycles
- Fixed file permissions: ug+rw(x)
- Permissions are really controlled just for distributed artifacts.
- Depends on Version4 glassfish-build-maven-plugin#145
|
We need also raise Maven version to 3.9.0+ in prerequisites. |
Yes, that is why I still keep it as a Draft PR. I want to check also if it compiles on Windows too. |
avpinchuk
reviewed
Sep 25, 2023
- Reviewed all assemblies and custom lifecycles - Fixed file permissions: ug+rw(x) - Permissions are really controlled just for distributed artifacts. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
pzygielo
approved these changes
Oct 1, 2023
- where possible is used 3.9.4 - or 3.9.3 where 3.9.4 is not available yet Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
avpinchuk
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.