GlassFishORBHelper changed to singleton, lifecycle #24806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Feb 12, 2024
•
dmatej
commented
- cherrypicked from Fixes for resource leaks #24616 + added two commits with code cleanup
- Original commit was created more than year ago, I think it was related to some race condition I noticed in logs, but now I am not sure. However I believe it is still bit better than older version. The CORBA/ORB initialization is a horrible thing - maybe it would be easier to rewrite it instead of refactoring. But that would need to know every piece of it first ...
avpinchuk
approved these changes
Feb 12, 2024
...er/orb/orb-connector/src/main/java/org/glassfish/enterprise/iiop/api/GlassFishORBHelper.java
Outdated
Show resolved
Hide resolved
arjantijms
approved these changes
Feb 13, 2024
- Hard to trace all paths, but it seems this behaves better - Using annotations instead of implements Signed-off-by: David Matějček <david.matejcek@omnifish.ee> # Conflicts: # appserver/orb/orb-connector/src/main/java/org/glassfish/enterprise/iiop/api/GlassFishORBHelper.java
- I would like to do more, but it has too many open ends connected even to different libraries like glassfish-corba-orb Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
… method. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
avpinchuk
reviewed
Feb 13, 2024
...er/orb/orb-connector/src/main/java/org/glassfish/enterprise/iiop/api/GlassFishORBHelper.java
Show resolved
Hide resolved
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.