Command recorder Admin Console plugin to configure admin command logging (with plain facelets, no JSF templating) #24898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndroMih
force-pushed
the
ondromih-new-admin-console
branch
from
d0937a3
to
49b9f9b
Compare
…ult view handler
URLs that start with /faces/* are handled by xhtml pages (e.g. /faces/header.xhtml handled by header.xhtml (in the webapp root). Can be injected to JSF templating pages via iframe. Example in upload.jsf (Application -> Deploy...)
Adds a custom resource handler wrapper that loads facelets from a console plugin, from the META-INF/resources directory. Adds a Console plugin for command recorder, which provides a menu facelet wtih a toggle button. The MenuView bean is not found yet.
Button to toggle Command logger Simplified plugins via Faces - plain JARs in Admin WAR, which contain facelets and resources in META-INF/resources, and Java model as plain CDI beans in the JAR. Subject is retrieved from Jakarta Security - worth to move to a common module.
OndroMih
force-pushed
the
ondromih-new-admin-console
branch
from
49b9f9b
to
af3df30
Compare
OndroMih
changed the title
…ommandrecorder plugin Moved all the code needed to integrate the Command Recorder console plugin into the plugin module. This means that Admin Console will work without issues if the module is not present. Since the Admin Recorder plugin is deployed in the AdminGUI application and not as an OSGi bundle in modules, I needed to update the ConsolePluginService: * it's now created by an HK2 locator specific to the deployed app, so that it finds console plugins also in the web app, not only in OSGi modules * it searches for all plugin configuration files in the classloader and remove duplicities (because the web app classloader also finds all files in OSGi bundles via the parent classloader) Also removed the demo facelets files.(header.xhtml, etc.)
OndroMih
force-pushed
the
ondromih-new-admin-console
branch
from
af3df30
to
c0991e8
Compare
Moved CDI producers into Admin Core, so that they can be reused by other modules and we avoid conflicts or implicit dependencies if multiple modules define the same producers or rely on beans produced by other modules.
OndroMih
force-pushed
the
ondromih-new-admin-console
branch
from
c0991e8
to
3bb8de0
Compare
|
@avpinchuk , @arjantijms , @dmatej , @pzygielo , @hs536, can you please review? I think this is an important PR for the future Admin Console development, which allows adding new features to the Admin console using plain Jakarta Faces facelets, with no JSF templating dependencies. |
pzygielo
reviewed
Jul 13, 2024
...ui/commandrecorder/src/main/java/org/glassfish/commandrecorder/admingui/CommandRecorder.java
Outdated
Show resolved
Hide resolved
Removed unnecessary Serializable
avpinchuk
reviewed
Jul 14, 2024
...dmingui/plugin-service/src/main/java/org/glassfish/admingui/plugin/ConsolePluginService.java
Show resolved
Hide resolved
appserver/admingui/war/src/main/java/org/glassfish/admingui/common/AdminGuiApplication.java
Outdated
Show resolved
Hide resolved
appserver/admingui/war/src/main/java/org/glassfish/admingui/common/AdminGuiViewHandler.java
Outdated
Show resolved
Hide resolved
...ui/commandrecorder/src/main/java/org/glassfish/commandrecorder/admingui/CommandRecorder.java
Outdated
Show resolved
Hide resolved
appserver/web/web-glue/src/main/java/com/sun/enterprise/web/WebModuleListener.java
Outdated
Show resolved
Hide resolved
avpinchuk
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
*.xhtmlfilesThis allows creating new pages in Admin Console using the standard Jakarta Faces facelets and bundle them in a JAR in the Admin GUI WAR. Those pages can be then injected into old JSF templating pages via iframe or ajax call. it's also possible to provide an injection point to the existing Admin Console pages via standard means, all in the same JAR file.
New Facelets should be placed into the root of the web app. Or, even better, in a separate JAR file inside the web app, into the `META-INF/resources/ directory. CDI beans can be places in the WAR or nested JAR as usual.